Bug 95426

Summary: Web Inspector: [WebGL] Link WebGL calls to the source code where it was made
Product: WebKit Reporter: Andrey Adaikin <aandrey>
Component: Web Inspector (Deprecated)Assignee: Andrey Adaikin <aandrey>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Andrey Adaikin
Reported 2012-08-30 00:24:02 PDT
Patch to follow.
Attachments
Patch (13.00 KB, patch)
2012-08-30 00:33 PDT, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Patch (13.17 KB, patch)
2012-08-31 01:01 PDT, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2012-08-30 00:33:27 PDT
Created attachment 161412 [details] Patch
Vsevolod Vlasov
Comment 2 2012-08-30 08:37:16 PDT
Comment on attachment 161412 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161412&action=review > Source/WebCore/inspector/front-end/WebGLProfileView.js:58 > + this._linkifier = new WebInspector.Linkifier(); this._linkifier.reset() is never called. > Source/WebCore/inspector/front-end/WebGLProfileView.js:114 > + var lineNumber = Math.max(0, call.lineNumber - 1) || 0; Why not just call.lineNumber - 1 if they are one based? > Source/WebCore/inspector/front-end/WebGLProfileView.js:122 > + var args = call.arguments || []; arguments is not optional in protocol, this check is probably redundant.
Vsevolod Vlasov
Comment 3 2012-08-30 08:43:37 PDT
Comment on attachment 161412 [details] Patch Please add this._linkifier.reset(), other than that looks good.
Andrey Adaikin
Comment 4 2012-08-31 01:01:27 PDT
Created attachment 161632 [details] Patch
WebKit Review Bot
Comment 5 2012-08-31 02:55:48 PDT
Comment on attachment 161632 [details] Patch Clearing flags on attachment: 161632 Committed r127243: <http://trac.webkit.org/changeset/127243>
WebKit Review Bot
Comment 6 2012-08-31 02:55:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.