Bug 95400

Summary: [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
Product: WebKit Reporter: Xianzhu Wang <wangxianzhu>
Component: Tools / TestsAssignee: Xianzhu Wang <wangxianzhu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Android   
Bug Depends on:    
Bug Blocks: 93627    
Attachments:
Description Flags
Patch
none
Patch none

Xianzhu Wang
Reported 2012-08-29 16:42:10 PDT
WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
Attachments
Patch (2.06 KB, patch)
2012-08-29 16:43 PDT, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
Patch (2.61 KB, patch)
2012-08-30 15:14 PDT, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xianzhu Wang
Comment 1 2012-08-29 16:43:54 PDT
Created attachment 161357 [details] Patch
Xianzhu Wang
Comment 2 2012-08-30 14:50:31 PDT
Adam and Dirk, could you review this change? Thanks.
Dirk Pranke
Comment 3 2012-08-30 14:58:15 PDT
Comment on attachment 161357 [details] Patch why don't you just include the directories below line 258? Also, I think that ever since I implemented support for cascading expectations, skipped directory names will skip all of the tests in the directory even if there are individual expectations for a test in earlier files. So, I don't think you need to call _real_tests() at all, you can just return a list of directories. We should test this, and if what I just wrote is wrong, fix the bugs and make it right :).
Xianzhu Wang
Comment 4 2012-08-30 15:14:43 PDT
Created attachment 161571 [details] Patch
Xianzhu Wang
Comment 5 2012-08-30 15:15:36 PDT
(In reply to comment #3) > (From update of attachment 161357 [details]) > why don't you just include the directories below line 258? > > Also, I think that ever since I implemented support for cascading expectations, skipped directory names will skip all of the tests in the directory even if there are individual expectations for a test in earlier files. So, I don't think you need to call _real_tests() at all, you can just return a list of directories. > > We should test this, and if what I just wrote is wrong, fix the bugs and make it right :). Great to know that. Tested and it works!
Dirk Pranke
Comment 6 2012-08-30 15:16:47 PDT
Comment on attachment 161571 [details] Patch much simpler :).
WebKit Review Bot
Comment 7 2012-08-30 15:57:31 PDT
Comment on attachment 161571 [details] Patch Clearing flags on attachment: 161571 Committed r127203: <http://trac.webkit.org/changeset/127203>
WebKit Review Bot
Comment 8 2012-08-30 15:57:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.