Bug 95385

Summary: IndexedDB: remove final createIndex backend glue
Product: WebKit Reporter: Alec Flett <alecflett>
Component: New BugsAssignee: Alec Flett <alecflett>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, dgrogan, fishd, gtk-ews, gustavo, gyuyoung.kim, jamesr, jsbell, rakuco, tkent+wkapi, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95409    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Alec Flett 2012-08-29 14:56:54 PDT 
IndexedDB: remove final createIndex backend glue
Comment 1 Alec Flett 2012-08-29 14:58:23 PDT 
Created attachment 161323 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-29 15:01:29 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2012-08-29 15:01:47 PDT 
Attachment 161323 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Build Bot 2012-08-29 15:13:17 PDT 
Comment on attachment 161323 [details]
Patch

Attachment 161323 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13694403
Comment 5 Alec Flett 2012-08-29 15:25:02 PDT 
Created attachment 161331 [details]
Patch
Comment 6 Alec Flett 2012-08-29 15:26:01 PDT 
jsbell/dgrogan - anything I missed here?
Comment 7 kov's GTK+ EWS bot 2012-08-29 15:31:57 PDT 
Comment on attachment 161331 [details]
Patch

Attachment 161331 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13691398
Comment 8 Joshua Bell 2012-08-29 15:37:26 PDT 
Can these be cleaned up too?

WebKit/chromium/public/platform/WebKitPlatformSupport.h 
WebKit/chromium/src/PlatformSupport.cpp 
WebCore/platform/chromium/PlatformSupport.h
Comment 9 Build Bot 2012-08-29 15:52:10 PDT 
Comment on attachment 161331 [details]
Patch

Attachment 161331 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13689427
Comment 10 Gyuyoung Kim 2012-08-29 16:27:02 PDT 
Comment on attachment 161331 [details]
Patch

Attachment 161331 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13689446
Comment 11 Alec Flett 2012-08-29 17:08:28 PDT 
Created attachment 161363 [details]
Patch
Comment 12 Alec Flett 2012-09-04 15:55:58 PDT 
abarth@ - quick review for code removal?
Comment 13 Adam Barth 2012-09-04 17:17:07 PDT 
Comment on attachment 161363 [details]
Patch

So many red lines!
Comment 14 WebKit Review Bot 2012-09-04 17:56:02 PDT 
Comment on attachment 161363 [details]
Patch

Clearing flags on attachment: 161363

Committed r127535: <http://trac.webkit.org/changeset/127535>
Comment 15 WebKit Review Bot 2012-09-04 17:56:07 PDT 
All reviewed patches have been landed.  Closing bug.