[chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState

• Component: New Bugs
• Status: RESOLVED FIXED

[Dana Jansens]

[chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState

[Dana Jansens]

Created attachment 161329 [details]
Patch

[Adrienne Walker]

Comment on attachment 161329 [details]
Patch

R=me.

[WebKit Review Bot]

Comment on attachment 161329 [details]
Patch

Rejecting attachment 161329 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/WebKit/chromium/tests/CCDrawQuadTest.cpp: In member function 'virtual void<unnamed>::CCDrawQuadTest_copyTileDrawQuad_Test::TestBody()':
Source/WebKit/chromium/tests/CCDrawQuadTest.cpp:273: error: 'EXPECT_INT_RECT_EQ' was not declared in this scope
  CXX(target) out/Release/obj.target/webkit_unit_tests/Source/WebKit/chromium/tests/CCLayerImplTest.o
make: *** [out/Release/obj.target/webkit_unit_tests/Source/WebKit/chromium/tests/CCDrawQuadTest.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/13746955

[James Robinson]

The macro you want is gone - use EXPECT_RECT_EQ().  I'm surprised EWS is green - methinks it didn't actually process the patch as rigorously as the bubble would imply.....

[James Robinson]

Or perhaps it ran before that rename.

[Dana Jansens]

(In reply to comment #4)
> The macro you want is gone - use EXPECT_RECT_EQ().  I'm surprised EWS is green - methinks it didn't actually process the patch as rigorously as the bubble would imply.....

Oh okay, thanks.

[Dana Jansens]

Created attachment 162308 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 162308 [details]
Patch for landing

Clearing flags on attachment: 162308

Committed r127699: <http://trac.webkit.org/changeset/127699>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.