Bug 95355

Summary: [EFL][WK2] Keep activePopupMenu to call valueChangedForPopupMenu() outside showPopupMenu()
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2012-08-29 09:44:27 PDT
Efl does not have a proper way to support nested loop so that applications may change values outside showPopupMenu. Like Qt port, WebKit2/Efl should keep activePopupMenu to change value of popup menu after showPopupMenu is finished.
Attachments
Patch (3.33 KB, patch)
2012-08-29 09:57 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (3.31 KB, patch)
2012-09-02 17:10 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2012-08-29 09:57:41 PDT
Created attachment 161255 [details] Patch
Gyuyoung Kim
Comment 2 2012-08-31 01:12:56 PDT
Comment on attachment 161255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161255&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:192 > +static Eina_Bool selectItemAfterDelayed(void* data) Please use standard boolean instead of Eina_Bool.
Gyuyoung Kim
Comment 3 2012-08-31 02:50:47 PDT
Comment on attachment 161255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161255&action=review >> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:192 >> +static Eina_Bool selectItemAfterDelayed(void* data) > > Please use standard boolean instead of Eina_Bool. callback function needs to use Eina_Bool. please ignore my previous comment.
Gyuyoung Kim
Comment 4 2012-08-31 03:20:18 PDT
Comment on attachment 161255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161255&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:195 > + return false; Is ECORE_CALLBACK_CANCEL more clear ?
Ryuan Choi
Comment 5 2012-09-02 17:10:46 PDT
Created attachment 161851 [details] Patch
Ryuan Choi
Comment 6 2012-09-02 17:12:37 PDT
(In reply to comment #4) > (From update of attachment 161255 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161255&action=review > > > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:195 > > + return false; > > Is ECORE_CALLBACK_CANCEL more clear ? Yes, it's more clear for efl folks. I fixed.
WebKit Review Bot
Comment 7 2012-09-02 19:03:52 PDT
Comment on attachment 161851 [details] Patch Clearing flags on attachment: 161851 Committed r127397: <http://trac.webkit.org/changeset/127397>
WebKit Review Bot
Comment 8 2012-09-02 19:03:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.