[Texmap] CSS Transform flicks at the end of animation

• Component: New Bugs
• Status: RESOLVED FIXED

[Rafael Brandao]

[Qt] CSS Transform flicks at the end of animation

[Rafael Brandao]

Created attachment 161231 [details]
Patch

[Rafael Brandao]

Do you think this patch is good? I have no idea how I'm supposed to test this, as the flick happens too fast but not always. I've left a debugging printf by purpose to show where you should slow down to make this easier to see.

[Alexander Pavlov (apavlov)]

Comment on attachment 161231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161231&action=review

> Source/WebCore/platform/graphics/TiledBackingStore.cpp:128
> +    printf("SLOW DOWN!!!");

Will you want to retain this in the landed patch?..

[Alexander Pavlov (apavlov)]

(In reply to comment #3)
> Will you want to retain this in the landed patch?..

Aha, I see the patch is not up for review yet. So, does the fix affect all platforms? Do you have any idea if this issue occurs on other platforms as well?

[Noam Rosenthal]

(In reply to comment #4)
> (In reply to comment #3)
> > Will you want to retain this in the landed patch?..
> 
> Aha, I see the patch is not up for review yet. So, does the fix affect all platforms? Do you have any idea if this issue occurs on other platforms as well?

The fix will only affect Qt/GTK/EFL, other platforms don't compile in GraphicsLayerAnimation.

[Noam Rosenthal]

Comment on attachment 161231 [details]
Patch

Good catch! I think this is the correct solution.

[Rafael Brandao]

Created attachment 161270 [details]
Patch

[WebKit Review Bot]

Comment on attachment 161270 [details]
Patch

Clearing flags on attachment: 161270

Committed r127072: <http://trac.webkit.org/changeset/127072>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.