Bug 95245

Summary: PutById uses DataLabel32, not DataLabelCompact
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix none

Gavin Barraclough
Reported 2012-08-28 14:17:33 PDT
JIT::resetPatchPutById calls the the wrong thing on x86-64 – this is moot right now, since they currently both do the same thing, but if we were to ever make compact mean 8-bit this could be a real problem. Also, don't rely on the object still being in eax on entry to the transition stub – this isn't very robust.
Attachments
Fix (3.61 KB, patch)
2012-08-29 15:26 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2012-08-28 14:20:57 PDT
Fixed in r126928
Gavin Barraclough
Comment 2 2012-08-28 17:00:41 PDT
Rolled back out in r126938 :-(
Gavin Barraclough
Comment 3 2012-08-29 15:26:55 PDT
Created attachment 161332 [details] Fix
Gavin Barraclough
Comment 4 2012-08-29 16:52:16 PDT
Re-reviewed by ggaren, relanded in r127066.
Note You need to log in before you can comment on or make changes to this bug.