Bug 9523

Summary: More Win32 build bustage
Product: WebKit Reporter: Ben Goodger <bengoodger>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
patch mjs: review+

Ben Goodger
Reported 2006-06-21 00:07:08 PDT
A bunch of files were added and removed: *Event.h/cpp and friends *RenderSelect.h/cpp Also: shouldInterruptJavaScript implementation does not match pure virtual base class signature, causing msvc to complain.
Attachments
patch (5.21 KB, patch)
2006-06-21 00:13 PDT, Ben Goodger
mjs: review+
Ben Goodger
Comment 1 2006-06-21 00:13:57 PDT
Created attachment 8938 [details] patch Adds/removes files from WebCore.vcproj and adjusts shouldInterruptJavaScript signature (alternatively, the impl should not be const, let me know) ChangeLog entry: * WebCore.vcproj/WebCore/WebCore.vcproj: Add DeprecatedRenderSelect.cpp/h Remove RenderSelect.cpp/h Add BeforeUnloadEvent, Clipboard, ClipboardEvent, Event, KeyboardEvent, MouseEvent, MouseRelatedEvent, MutationEvent, RegisteredEventListener, UIEvent, UIEventWithKeyState, WheelEvent .h/.cpp Remove dom2_eventsimpl.h/cpp * WebCore/bridge/win/FrameWin.cpp (WebCore::shouldInterruptJavaScript): This method is supposed to be implemented on FrameWin * WebCore/page/Frame.h (WebCore::Frame): abstract method should match const-ness of implementation
Maciej Stachowiak
Comment 2 2006-06-21 01:01:02 PDT
Comment on attachment 8938 [details] patch r=me
Ben Goodger
Comment 3 2006-06-21 01:21:49 PDT
Actually, this should probably make the windows impl non-const since otherwise this will break Mac builds (as dwf points out in #webkit) If someone checks this in tonight, they should make this correction (my tree that I did this patch in is at work)
David Kilzer (:ddkilzer)
Comment 4 2006-06-21 03:59:58 PDT
Committed by Adele in r14941.
Note You need to log in before you can comment on or make changes to this bug.