Bug 95228

Summary: [WK2] Expose process model as API
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch jhoneycutt: review+

Alexey Proskuryakov
Reported 2012-08-28 12:19:26 PDT
Patch forthcoming.
Attachments
proposed patch (5.84 KB, patch)
2012-08-28 12:24 PDT, Alexey Proskuryakov 		jhoneycutt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-08-28 12:24:11 PDT
Created attachment 161030 [details] proposed patch
Alexey Proskuryakov
Comment 2 2012-08-28 13:09:50 PDT
Committed <http://trac.webkit.org/changeset/126918>.
Darin Adler
Comment 3 2012-08-28 13:28:07 PDT
Comment on attachment 161030 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=161030&action=review > Source/WebKit2/UIProcess/WebContext.cpp:262 > + // Guard against API misuse. > + if (!m_processes.isEmpty()) > + CRASH(); Seems really harsh! Why not just return and do nothing?
Alexey Proskuryakov
Comment 4 2012-08-28 13:38:46 PDT
Silently ignoring the call would result in client developer wasting time to figure out what went wrong. I don't see any downside to crashing here, even if it may look a little unusual.
Note You need to log in before you can comment on or make changes to this bug.