Bug 95226

Summary: Rebaseline details-nested-2.html and clone-anonymous-block-non-inline-child-crash.html after 126789
Product: WebKit Reporter: Philip Rogers <pdr>
Component: New BugsAssignee: Philip Rogers <pdr>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, inferno, jchaffraix, morrita, rakuco, tasak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Rebaseline details-nested-2.html and clone-anonymous-block-non-inline-child-crash.html after 126789 inferno: review+, inferno: commit-queue+

Philip Rogers
Reported 2012-08-28 11:51:33 PDT
Rebaseline details-nested-2.html and clone-anonymous-block-non-inline-child-crash.html after 126789
Attachments
Rebaseline details-nested-2.html and clone-anonymous-block-non-inline-child-crash.html after 126789 (23.08 KB, patch)
2012-08-28 11:55 PDT, Philip Rogers 		inferno: review+
inferno: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philip Rogers
Comment 1 2012-08-28 11:55:19 PDT
Created attachment 161027 [details] Rebaseline details-nested-2.html and clone-anonymous-block-non-inline-child-crash.html after 126789
Abhishek Arya
Comment 2 2012-08-28 12:42:06 PDT
http://trac.webkit.org/changeset/126789/trunk/LayoutTests/platform/mac/fast/html/details-nested-2-expected.txt part of the change is wrong. Since we shouldn't be adding empty anonymous block, see http://trac.webkit.org/changeset/120477. That was a pretty nasty google docs bug, so it looks like r126789 is bringing it back and needs to be investigated. this part of the change (removing)"RenderInline {LABEL} at (0,0) size 0x0" is benign since it won't make a rendering difference.
Abhishek Arya
Comment 3 2012-08-28 13:01:42 PDT
(In reply to comment #2) > http://trac.webkit.org/changeset/126789/trunk/LayoutTests/platform/mac/fast/html/details-nested-2-expected.txt part of the change is wrong. Since we shouldn't be adding empty anonymous block, see http://trac.webkit.org/changeset/120477. That was a pretty nasty google docs bug, so it looks like r126789 is bringing it back and needs to be investigated. Under a details tag, it will be ok, since children are forced to be blocks, but if both inline and block children are allowed, we will run into case like the test in r120477. We should let morrita@ and tasak@ to decide what to do here. > > this part of the change (removing)"RenderInline {LABEL} at (0,0) size 0x0" is benign since it won't make a rendering difference.
Abhishek Arya
Comment 4 2012-08-28 13:12:23 PDT
Comment on attachment 161027 [details] Rebaseline details-nested-2.html and clone-anonymous-block-non-inline-child-crash.html after 126789 r+ing since these are just rebaselines, exactly same as the patch. if there is a bug in patch, it needs to be seperately handled and discussed.
Abhishek Arya
Comment 5 2012-08-28 13:13:02 PDT
Tasak@, can you please file a followup bug on c#2.
Philip Rogers
Comment 6 2012-08-28 13:36:46 PDT
Committed as http://trac.webkit.org/changeset/126923
Note You need to log in before you can comment on or make changes to this bug.