Bug 95157

Summary:

Bot bug for replacing JSC::UString by WTF::String

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

JavaScriptCore

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cmarcelo, gtk-ews, gustavo, gyuyoung.kim, haraken, japhet, mifenton, philn, rakuco, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	gyuyoung.kim: commit-queue-

Benjamin Poulain

Reported 2012-08-27 17:41:30 PDT

Lots of work for the bots, especially on Windows.

Attachments
Patch (531.98 KB, patch) 2012-08-27 18:25 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (492.36 KB, patch) 2012-08-27 19:50 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (494.96 KB, patch) 2012-08-27 23:19 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (497.39 KB, patch) 2012-08-28 12:33 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (497.39 KB, patch) 2012-08-28 14:12 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (497.47 KB, patch) 2012-08-28 15:18 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (525.81 KB, patch) 2012-08-29 15:34 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (532.52 KB, patch) 2012-08-29 17:04 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (540.95 KB, patch) 2012-08-29 19:39 PDT, Benjamin Poulain	gyuyoung.kim: commit-queue-	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2012-08-27 18:25:01 PDT

Created attachment 160880 [details] Patch

WebKit Review Bot

Comment 2 2012-08-27 18:27:41 PDT

Attachment 160880 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackFuncti..." exit_code: 1 Source/WebCore/bridge/objc/objc_runtime.h:137: _item is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 269 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2012-08-27 19:02:42 PDT

Comment on attachment 160880 [details] Patch Attachment 160880 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13644155

Early Warning System Bot

Comment 4 2012-08-27 19:12:42 PDT

Comment on attachment 160880 [details] Patch Attachment 160880 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13635166

Early Warning System Bot

Comment 5 2012-08-27 19:27:28 PDT

Comment on attachment 160880 [details] Patch Attachment 160880 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13638144

Gyuyoung Kim

Comment 6 2012-08-27 19:31:19 PDT

Comment on attachment 160880 [details] Patch Attachment 160880 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13646152

Benjamin Poulain

Comment 7 2012-08-27 19:50:27 PDT

Created attachment 160887 [details] Patch

WebKit Review Bot

Comment 8 2012-08-27 19:54:35 PDT

Attachment 160887 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackFuncti..." exit_code: 1 Source/WebCore/bridge/objc/objc_runtime.h:137: _item is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 254 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 9 2012-08-27 20:26:50 PDT

Comment on attachment 160887 [details] Patch Attachment 160887 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13651050

Gyuyoung Kim

Comment 10 2012-08-27 21:17:18 PDT

Comment on attachment 160887 [details] Patch Attachment 160887 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13652040

Gyuyoung Kim

Comment 11 2012-08-27 21:22:03 PDT

Comment on attachment 160887 [details] Patch Attachment 160887 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13658024

Benjamin Poulain

Comment 12 2012-08-27 23:19:17 PDT

Created attachment 160908 [details] Patch

WebKit Review Bot

Comment 13 2012-08-27 23:23:13 PDT

Attachment 160908 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackFuncti..." exit_code: 1 Source/WebCore/bridge/objc/objc_runtime.h:137: _item is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 256 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gyuyoung Kim

Comment 14 2012-08-27 23:51:08 PDT

Comment on attachment 160908 [details] Patch Attachment 160908 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13661077

Build Bot

Comment 15 2012-08-28 00:01:01 PDT

Comment on attachment 160908 [details] Patch Attachment 160908 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13660075

Benjamin Poulain

Comment 16 2012-08-28 12:33:55 PDT

Created attachment 161034 [details] Patch

WebKit Review Bot

Comment 17 2012-08-28 12:37:32 PDT

Attachment 161034 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackFuncti..." exit_code: 1 Source/WebCore/bridge/objc/objc_runtime.h:137: _item is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 257 files If any of these errors are false positives, please file a bug against check-webkit-style.

Benjamin Poulain

Comment 18 2012-08-28 14:12:10 PDT

Created attachment 161058 [details] Patch

WebKit Review Bot

Comment 19 2012-08-28 14:14:51 PDT

Attachment 161058 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackFuncti..." exit_code: 1 Source/WebCore/bridge/objc/objc_runtime.h:137: _item is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 257 files If any of these errors are false positives, please file a bug against check-webkit-style.

Benjamin Poulain

Comment 20 2012-08-28 14:35:15 PDT

Comment on attachment 161058 [details] Patch Not for review, sorry about that.

Build Bot

Comment 21 2012-08-28 15:07:12 PDT

Comment on attachment 161058 [details] Patch Attachment 161058 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13662394

Benjamin Poulain

Comment 22 2012-08-28 15:18:31 PDT

Created attachment 161072 [details] Patch

WebKit Review Bot

Comment 23 2012-08-28 15:27:46 PDT

Attachment 161072 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackFuncti..." exit_code: 1 Source/WebCore/bridge/objc/objc_runtime.h:137: _item is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 257 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gyuyoung Kim

Comment 24 2012-08-28 16:45:04 PDT

Comment on attachment 161072 [details] Patch Attachment 161072 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13661466

Benjamin Poulain

Comment 25 2012-08-28 19:23:59 PDT

https://bugs.webkit.org/show_bug.cgi?id=95271

Benjamin Poulain

Comment 26 2012-08-29 15:34:42 PDT

Reopening to attach new patch.

Benjamin Poulain

Comment 27 2012-08-29 15:34:49 PDT

Created attachment 161335 [details] Patch

kov's GTK+ EWS bot

Comment 28 2012-08-29 16:06:59 PDT

Comment on attachment 161335 [details] Patch Attachment 161335 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13682404

Gyuyoung Kim

Comment 29 2012-08-29 16:54:29 PDT

Comment on attachment 161335 [details] Patch Attachment 161335 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13684438

Benjamin Poulain

Comment 30 2012-08-29 17:04:18 PDT

Created attachment 161362 [details] Patch

Gyuyoung Kim

Comment 31 2012-08-29 19:30:41 PDT

It looks this patch needs to be rebase first. Anyway, EFL build is fine with latest patch. :) Thanks.

Benjamin Poulain

Comment 32 2012-08-29 19:39:13 PDT

Created attachment 161390 [details] Patch

Gyuyoung Kim

Comment 33 2012-08-29 20:42:58 PDT

Comment on attachment 161390 [details] Patch Attachment 161390 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13681520

Benjamin Poulain

Comment 34 2012-08-29 20:51:46 PDT

Comment on attachment 161390 [details] Patch Not for review.

Gyuyoung Kim

Comment 35 2012-08-29 21:03:15 PDT

(In reply to comment #33) > (From update of attachment 161390 [details]) > Attachment 161390 [details] did not pass efl-ews (efl): > Output: http://queues.webkit.org/results/13681520 To pass EFL EWS, EFL EWS needs to generate DerivedSource again. Please land this patch regardless of EFL EWS. I already checked this patch in my box.

Benjamin Poulain

Comment 36 2012-08-29 21:04:58 PDT

GTK seems to also have weird bot issues. Waiting for Windows now...

Benjamin Poulain

Comment 37 2012-08-30 21:00:36 PDT

Done

Note You need to log in before you can comment on or make changes to this bug.