Bug 95139 – [BlackBerry] Spellcheck should be enabled if undefined in content

• Component: WebKit BlackBerry
• Status: RESOLVED FIXED

[Nima Ghanavatian]

Currently we only enable spellcheck if it is defined as such in the web content explicitly.
Making this change to enable by default, and only turn off if it is explicitly set, or if we expect the field to be a username, email or url.

[Nima Ghanavatian]

Created attachment 160974 [details]
Patch

[Rob Buis]

Comment on attachment 160974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160974&action=review

Looks good.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.h:202
> +    bool shouldSpellCheckElement(const WebCore::Element*);

Can the method be const?

[Nima Ghanavatian]

Created attachment 160999 [details]
Patch

[Rob Buis]

Comment on attachment 160999 [details]
Patch

Looks good.

[WebKit Review Bot]

Comment on attachment 160999 [details]
Patch

Attachment 160999 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13653408

New failing tests:
http/tests/security/mixedContent/filesystem-url-in-iframe.html

[WebKit Review Bot]

Created attachment 161008 [details]
Archive of layout-test-results from gce-cr-linux-08

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[WebKit Review Bot]

Comment on attachment 160999 [details]
Patch

Rejecting attachment 160999 [details] from commit-queue.

Path LayoutTests/platform/chromium/virtual/gpu/fast/canvas/webgl/shader-precision-format.html does not exist.
Full output: http://queues.webkit.org/results/13662333

[WebKit Review Bot]

Comment on attachment 160999 [details]
Patch

Clearing flags on attachment: 160999

Committed r126925: <http://trac.webkit.org/changeset/126925>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.