Bug 95108

Summary: [Skia/Chromium] Remove use of deprecated Skia names
Product: WebKit Reporter: Brian Salomon <bsalomon>
Component: New BugsAssignee: Brian Salomon <bsalomon>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, jamesr, senorblanco, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Brian Salomon
Reported 2012-08-27 11:28:24 PDT
[Skia/Chromium] Remove use of deprecated Skia names
Attachments
Patch (4.81 KB, patch)
2012-08-27 11:30 PDT, Brian Salomon 		no flags
DetailsFormatted DiffDiff
Patch (4.81 KB, patch)
2012-08-27 11:32 PDT, Brian Salomon 		no flags
DetailsFormatted DiffDiff
Patch (4.83 KB, patch)
2012-08-27 12:59 PDT, Brian Salomon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brian Salomon
Comment 1 2012-08-27 11:30:26 PDT
Created attachment 160757 [details] Patch
Stephen White
Comment 2 2012-08-27 11:32:07 PDT
Comment on attachment 160757 [details] Patch Looks good, bots willing. r=me
Brian Salomon
Comment 3 2012-08-27 11:32:59 PDT
Created attachment 160759 [details] Patch
Brian Salomon
Comment 4 2012-08-27 11:34:24 PDT
Hey Stephen, My first patch had some bad spacing in the Changelog file that I fixed in the second patch.
Stephen White
Comment 5 2012-08-27 11:45:22 PDT
Comment on attachment 160759 [details] Patch OK. r=me
WebKit Review Bot
Comment 6 2012-08-27 12:32:53 PDT
Comment on attachment 160759 [details] Patch Rejecting attachment 160759 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: e/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Even up WTF::String to CString functions When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13616284
Brian Salomon
Comment 7 2012-08-27 12:59:45 PDT
Created attachment 160785 [details] Patch
Brian Salomon
Comment 8 2012-08-27 13:00:56 PDT
The last patch failed due to a Changelog conflict. I'm not sure why; I svn updated just before running webkit-patch. I any event the new patch is the same as the old patch (just against a later Changelog).
WebKit Review Bot
Comment 9 2012-08-27 14:22:07 PDT
Comment on attachment 160785 [details] Patch Clearing flags on attachment: 160785 Committed r126795: <http://trac.webkit.org/changeset/126795>
WebKit Review Bot
Comment 10 2012-08-27 14:22:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.