| Summary: | [webkit-patch] Don't crash chrome-channels command when a previously unknown platform shows up. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gavin Peters <gavinp> | ||||||||||
| Component: | New Bugs | Assignee: | Gavin Peters <gavinp> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | abarth, dglazkov, dpranke, eric, ojan, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Gavin Peters
2012-08-27 11:00:00 PDT
Created attachment 160748 [details]
Patch
Comment on attachment 160748 [details]
Patch
eseidel, wdyt?
Comment on attachment 160748 [details] Patch Attachment 160748 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13613261 New failing tests: animations/suspend-resume-animation-events.html Created attachment 160763 [details]
Archive of layout-test-results from gce-cr-linux-06
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment on attachment 160748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160748&action=review > Tools/Scripts/webkitpy/common/net/omahaproxy.py:71 > + pretty_platform = self.chrome_platforms[platform["os"]] if platform["os"] in self.chrome_platforms else platform["os"] self.chrome_platforms.get(platform["os"], platform["os"]) Created attachment 160777 [details]
Patch
(In reply to comment #5) > (From update of attachment 160748 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=160748&action=review > > > Tools/Scripts/webkitpy/common/net/omahaproxy.py:71 > > + pretty_platform = self.chrome_platforms[platform["os"]] if platform["os"] in self.chrome_platforms else platform["os"] > > self.chrome_platforms.get(platform["os"], platform["os"]) Aha, yes. I'm glad someone here knows python. Created attachment 160781 [details]
Patch
Comment on attachment 160781 [details] Patch Clearing flags on attachment: 160781 Committed r126792: <http://trac.webkit.org/changeset/126792> All reviewed patches have been landed. Closing bug. |