Bug 95104

Summary: [webkit-patch] Don't crash chrome-channels command when a previously unknown platform shows up.
Product: WebKit Reporter: Gavin Peters <gavinp>
Component: New BugsAssignee: Gavin Peters <gavinp>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, dpranke, eric, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from gce-cr-linux-06
none
Patch
none
Patch none

Gavin Peters
Reported 2012-08-27 11:00:00 PDT
[webkit-patch] Don't crash chrome-channels command when a previously unknown platform shows up.
Attachments
Patch (4.49 KB, patch)
2012-08-27 11:01 PDT, Gavin Peters 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-06 (585.24 KB, application/zip)
2012-08-27 11:46 PDT, WebKit Review Bot 		no flags
Details
Patch (4.44 KB, patch)
2012-08-27 12:37 PDT, Gavin Peters 		no flags
DetailsFormatted DiffDiff
Patch (4.33 KB, patch)
2012-08-27 12:44 PDT, Gavin Peters 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gavin Peters
Comment 1 2012-08-27 11:01:16 PDT
Created attachment 160748 [details] Patch
Gavin Peters
Comment 2 2012-08-27 11:02:22 PDT
Comment on attachment 160748 [details] Patch eseidel, wdyt?
WebKit Review Bot
Comment 3 2012-08-27 11:46:12 PDT
Comment on attachment 160748 [details] Patch Attachment 160748 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13613261 New failing tests: animations/suspend-resume-animation-events.html
WebKit Review Bot
Comment 4 2012-08-27 11:46:15 PDT
Created attachment 160763 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Adam Barth
Comment 5 2012-08-27 12:02:27 PDT
Comment on attachment 160748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160748&action=review > Tools/Scripts/webkitpy/common/net/omahaproxy.py:71 > + pretty_platform = self.chrome_platforms[platform["os"]] if platform["os"] in self.chrome_platforms else platform["os"] self.chrome_platforms.get(platform["os"], platform["os"])
Gavin Peters
Comment 6 2012-08-27 12:37:42 PDT
Created attachment 160777 [details] Patch
Gavin Peters
Comment 7 2012-08-27 12:39:03 PDT
(In reply to comment #5) > (From update of attachment 160748 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=160748&action=review > > > Tools/Scripts/webkitpy/common/net/omahaproxy.py:71 > > + pretty_platform = self.chrome_platforms[platform["os"]] if platform["os"] in self.chrome_platforms else platform["os"] > > self.chrome_platforms.get(platform["os"], platform["os"]) Aha, yes. I'm glad someone here knows python.
Gavin Peters
Comment 8 2012-08-27 12:44:43 PDT
Created attachment 160781 [details] Patch
WebKit Review Bot
Comment 9 2012-08-27 13:58:43 PDT
Comment on attachment 160781 [details] Patch Clearing flags on attachment: 160781 Committed r126792: <http://trac.webkit.org/changeset/126792>
WebKit Review Bot
Comment 10 2012-08-27 13:58:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.