Bug 95086

Summary: [EFL][WK2] Free Url_Bar on program exit
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: lucas.de.marchi, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sudarsana Nagineni (babu)
Reported 2012-08-27 07:26:03 PDT
Url_Bar is leaky here. We must free it on program exit. =1801== 24 bytes in 1 blocks are definitely lost in loss record 240 of 1,375 ==1801== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==1801== by 0x4020E6: url_bar_add (url_bar.c:91) ==1801== by 0x402CAD: browserCreate (main.c:246) ==1801== by 0x402DD2: main (main.c:286)
Attachments
Patch (1008 bytes, patch)
2012-08-27 07:40 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2012-08-27 07:40:46 PDT
Created attachment 160715 [details] Patch
Eric Seidel (no email)
Comment 2 2012-08-27 13:16:59 PDT
Comment on attachment 160715 [details] Patch I guess in c you don't have destructors Seems Browser should have a destroy() function that does this for you though... None of this code matters... in fact, you're just slowing down exit. BUt I can imagine it might be useful to clean this up for leak detection. rs=me.
WebKit Review Bot
Comment 3 2012-08-27 13:31:37 PDT
Comment on attachment 160715 [details] Patch Clearing flags on attachment: 160715 Committed r126788: <http://trac.webkit.org/changeset/126788>
WebKit Review Bot
Comment 4 2012-08-27 13:31:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.