Bug 95054 – [Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Balazs Ankes]

--- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/css/image-set-setting-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/css/image-set-setting-actual.txt 
@@ -5,13 +5,13 @@
 
 
 Single value for background-image : url('http://www.webkit.org/a') 1x
-PASS testComputedStyle("background-image", "url('http://www.webkit.org/a') 1x") is "-webkit-image-set(url(http://www.webkit.org/a), 1)"
+FAIL testComputedStyle("background-image", "url('http://www.webkit.org/a') 1x") should be -webkit-image-set(url(http://www.webkit.org/a), 1). Was .
 
 Multiple values for background-image : url('http://www.webkit.org/a') 1x, url('http://www.webkit.org/b') 2x
-PASS testComputedStyle("background-image", "url('http://www.webkit.org/a') 1x, url('http://www.webkit.org/b') 2x") is "-webkit-image-set(url(http://www.webkit.org/a), 1, url(http://www.webkit.org/b), 2)"
+FAIL testComputedStyle("background-image", "url('http://www.webkit.org/a') 1x, url('http://www.webkit.org/b') 2x") should be -webkit-image-set(url(http://www.webkit.org/a), 1, url(http://www.webkit.org/b), 2). Was .
 
 Multiple values for background-image, out of order : url('http://www.webkit.org/c') 3x, url('http://www.webkit.org/b') 2x, url('http://www.webkit.org/a') 1x
-PASS testComputedStyle("background-image", "url('http://www.webkit.org/c') 3x, url('http://www.webkit.org/b') 2x, url('http://www.webkit.org/a') 1x") is "-webkit-image-set(url(http://www.webkit.org/c), 3, url(http://www.webkit.org/b), 2, url(http://www.webkit.org/a), 1)"
+FAIL testComputedStyle("background-image", "url('http://www.webkit.org/c') 3x, url('http://www.webkit.org/b') 2x, url('http://www.webkit.org/a') 1x") should be -webkit-image-set(url(http://www.webkit.org/c), 3, url(http://www.webkit.org/b), 2, url(http://www.webkit.org/a), 1). Was .
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Balazs Ankes]

Skip committed in r126733. Please unskip it with proper fix.

[Simon Fraser (smfr)]

Looks like image-set is disabled in Qt?

[Anish]

Created attachment 160769 [details]
fix for bug 95054

updated skipped files to skip image-set-setting test

[Simon Hausmann]

Yeah, and it looks like that we should enable it.

[Simon Hausmann]

Created attachment 160784 [details]
Patch

Somewhat untested patch to enable CSS_IMAGE_SET

[Eric Seidel (no email)]

Comment on attachment 160784 [details]
Patch

OK.

[Eric Seidel (no email)]

I suspect there is a more modern way to turn on flags than Platform.h, but this seems OK.

[Simon Hausmann]

Comment on attachment 160784 [details]
Patch

Clearing cq. I'll land it manually tomorrow. Want to be on the safe side :)

[Simon Hausmann]

(In reply to comment #7)
> I suspect there is a more modern way to turn on flags than Platform.h, but this seems OK.

Oh right, I should've touched Tools/qmake/mkspecs/features/features.pri :/

[Simon Hausmann]

Comment on attachment 160769 [details]
fix for bug 95054

Marking this as obsolete. For Qt we should enable the feature (working on it) and the skipping of win and wincairo should not be done in a [Qt] bug :)

[Simon Hausmann]

(In reply to comment #6)
> (From update of attachment 160784 [details])
> OK.

Thanks :) Will land this with the feature flag enable location corrected (features.pri instead of Platform.h)

[Simon Hausmann]

Committed r126858: <http://trac.webkit.org/changeset/126858>