Bug 95017

Summary: Roll out r126056 - patch broke path.getBBox()
Product: WebKit Reporter: Philip Rogers <pdr>
Component: SVGAssignee: Philip Rogers <pdr>
Status: RESOLVED FIXED    
Severity: Normal CC: krit, webkit.review.bot, zimmermann
Priority: P2    
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Roll out r126056 and r126626 none

Philip Rogers
Reported 2012-08-25 17:18:13 PDT
I removed the virtual getBBox() code in SVGPathElement.cpp which was incorrect and resulted in a test breaking. In the future I will better rely on ChangeLogs, as Tim Horton's r99460 was clear about why this code was organized this way: the boundingRect() call in SVGPathElement returns the _tight_ bounds so that paths don't use the loose/fast bounding rect from m_objectBoundingBox. This test was already skipped on Chromium for other reasons (see: https://bugs.webkit.org/show_bug.cgi?id=65939) and I failed to catch this regression locally.
Attachments
Roll out r126056 and r126626 (3.70 KB, patch)
2012-08-25 17:25 PDT, Philip Rogers 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philip Rogers
Comment 1 2012-08-25 17:25:57 PDT
Created attachment 160582 [details] Roll out r126056 and r126626
WebKit Review Bot
Comment 2 2012-08-25 18:16:24 PDT
Comment on attachment 160582 [details] Roll out r126056 and r126626 Clearing flags on attachment: 160582 Committed r126693: <http://trac.webkit.org/changeset/126693>
WebKit Review Bot
Comment 3 2012-08-25 18:16:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.