Bug 9498

Summary: Remove dead code left in JSHTMLDocument::getOwnPropertySlot() from r14298 (Bug 7838)
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, darin, ggaren
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Patch v1 darin: review+

David Kilzer (:ddkilzer)
Reported 2006-06-18 15:34:34 PDT
While attempting to fix Bug 9179, I noticed that JSHTMLDocument::getOwnPropertySlot() contained some code that could never be reached. The patch I will attach removes it, although I'm not sure if this was the desired result of the original fix for Bug 7838.
Attachments
Patch v1 (1.45 KB, patch)
2006-06-18 15:37 PDT, David Kilzer (:ddkilzer) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2006-06-18 15:37:06 PDT
Created attachment 8910 [details] Patch v1 Removes dead code from JSHTMLDocument::getOwnPropertySlot(). Again, I'm not sure if this was the original intent of the change to this method in for Bug 7838 in r14298.
Darin Adler
Comment 2 2006-06-18 16:39:49 PDT
Comment on attachment 8910 [details] Patch v1 r=me
David Kilzer (:ddkilzer)
Comment 3 2006-06-18 16:50:30 PDT
Committed revision 14908.
Note You need to log in before you can comment on or make changes to this bug.