Bug 94947

Summary: Web Inspector: do not count weak and shortcut edges when calculating distance to window
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch yurys: review+

Yury Semikhatsky
Reported 2012-08-24 09:44:59 PDT
When calculating distance from an object to Window in heap profiler we should only take into account strong real references. This means that shortcuts and weak edges should be ignored.
Attachments
Patch (2.53 KB, patch)
2012-08-24 09:48 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (2.78 KB, patch)
2012-08-24 10:02 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-08-24 09:48:09 PDT
Created attachment 160439 [details] Patch
Yury Semikhatsky
Comment 2 2012-08-24 09:58:02 PDT
Comment on attachment 160439 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160439&action=review > Source/WebCore/inspector/front-end/HeapSnapshot.js:958 > + var edgeType = containmentEdges[edgeToNodeIndex - edgeToNodeOffset + edgeTypeOffset]; This looks ugly. Let's iterate over edgeIndexes and add appropriate offsets instead of first adding and then subtracting the offsets.
Ilya Tikhonovsky
Comment 3 2012-08-24 10:02:51 PDT
Created attachment 160442 [details] Patch
Ilya Tikhonovsky
Comment 4 2012-08-24 10:05:33 PDT
comments addressed
Ilya Tikhonovsky
Comment 5 2012-08-24 10:10:01 PDT
Committed r126595: <http://trac.webkit.org/changeset/126595>
Note You need to log in before you can comment on or make changes to this bug.