Summary: | Rename RegisterProtocolHandler API to NavigatorContentUtils | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||||
Component: | WebKit Misc. | Assignee: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, gustavo, gyuyoung.kim, hausmann, kenneth, mifenton, morrita, ojan, philn, rakuco, vestbo, webkit.review.bot, xan.lopez | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 119239 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Mikhail Pozdnyakov
2012-08-24 04:08:04 PDT
Created attachment 160420 [details]
patch
Created attachment 160426 [details]
patch
Improvements comparing to preliminary patch: Fixed GTK build( hopefully :) ), fixed alphabetical order in some files.
Utils is often a bad name as it is very generic Sorry I see that is what is used in the spec, so it is ok Comment on attachment 160426 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=160426&action=review > Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.idl:25 > + ] NavigatorContentUtils { Can we add a comment referencing the spec so folks know where the name comes from? Comment on attachment 160426 [details] patch Rejecting attachment 160426 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 134927. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13600304 Sorry, you hit a bug in the commit-queue. I need to track it down. Comment on attachment 160426 [details] patch Rejecting attachment 160426 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Log Auto-merging Source/WebKit/chromium/src/WebViewImpl.cpp Failed to merge in the changes. Patch failed at 0001 [chromium] Convert WebLayerTreeView interface into pure virtual When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13594352 Comment on attachment 160426 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=160426&action=review > ChangeLog:3 > + bug94920 Actually, it looks like your ChangeLog is malformed. Notice that your ChangeLog entry doesn't follow the same format as the rest. Created attachment 160654 [details]
to be landed
Added reference to spec into .idl file, fixed ChangeLog formatting. Adam, thanks for review!
Comment on attachment 160654 [details] to be landed Clearing flags on attachment: 160654 Committed r126735: <http://trac.webkit.org/changeset/126735> All reviewed patches have been landed. Closing bug. |