Bug 94912 – defineProperty to global cached variable on global object does not effect

• Component: JavaScriptCore
• Status: UNCONFIRMED

[Yusuke Suzuki]

Currently JSGlobalObject::defineOwnProperty doesn't handle variables cached as global register correctly.

So for example,

// test.js
var i = 0;
print(i);  // 0
print(this.i);  // 0
Object.defineProperty(this, 'i', {
  value: 1
});
print(i);  // 0
print(this.i);  // 1

$ jsc test.js

To fix this, we should store defined value to global register correctly.

[Yusuke Suzuki]

Created attachment 160359 [details]
Patch

[WebKit Review Bot]

Comment on attachment 160359 [details]
Patch

Attachment 160359 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13574705

New failing tests:
fast/js/global-defineProperty.html

[WebKit Review Bot]

Created attachment 160370 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Yusuke Suzuki]

Oops, I'll add expected file for V8 soon.

[Yusuke Suzuki]

Created attachment 160380 [details]
Patch

attached patch v2

[Geoffrey Garen]

Sure would be nice to have a helper function for all these "invalid defineOwnProperty" conditions.

[EFL EWS Bot]

Comment on attachment 160380 [details]
Patch

Attachment 160380 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/199558

[Anders Carlsson]

Comment on attachment 160380 [details]
Patch

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.