Bug 94900

Summary: Web Inspector: resolve URLs upon creation, get rid of populateHrefContextMenu
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, ossy, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from gce-cr-linux-03
none
Patch vsevik: review+

Pavel Feldman
Reported 2012-08-23 22:40:13 PDT
- This change makes sure we resolve URLs upon adding the to the UI. Then we treat them as absolute links in context menu, etc. - There is no need to override context menu for links anymore - system menu will do.
Attachments
Patch (19.84 KB, patch)
2012-08-23 23:15 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-03 (330.42 KB, application/zip)
2012-08-24 01:52 PDT, WebKit Review Bot 		no flags
Details
Patch (23.89 KB, patch)
2012-08-24 03:09 PDT, Pavel Feldman 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-08-23 23:15:54 PDT
Created attachment 160336 [details] Patch
WebKit Review Bot
Comment 2 2012-08-24 01:52:43 PDT
Comment on attachment 160336 [details] Patch Attachment 160336 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13604003 New failing tests: inspector/styles/styles-url-linkify.html inspector/elements/elements-panel-rewrite-href.html
WebKit Review Bot
Comment 3 2012-08-24 01:52:46 PDT
Created attachment 160360 [details] Archive of layout-test-results from gce-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Pavel Feldman
Comment 4 2012-08-24 03:09:32 PDT
Created attachment 160373 [details] Patch
Pavel Feldman
Comment 5 2012-08-24 05:10:30 PDT
Committed r126572: <http://trac.webkit.org/changeset/126572>
Csaba Osztrogonác
Comment 6 2012-08-24 05:55:41 PDT
(In reply to comment #5) > Committed r126572: <http://trac.webkit.org/changeset/126572> It broke a test at least on Qt: --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/elements/iframe-load-event-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/elements/iframe-load-event-actual.txt @@ -1,6 +1,7 @@ Tests that iframe content is available after iframe's load event fired. See bug 76552. +error: Could not resolve DOM URL: resources/iframe-load-event-iframe-2.html After frame navigate @@ -25,6 +26,7 @@ </body> </html> </iframe> + - <div> </body> </html> Could you check it, please?
Pavel Feldman
Comment 7 2012-08-24 05:59:10 PDT
Looking...
Pavel Feldman
Comment 8 2012-08-24 06:14:45 PDT
(In reply to comment #7) > Looking... Fix landed as http://trac.webkit.org/changeset/126576.
Note You need to log in before you can comment on or make changes to this bug.