Bug 94871

Summary: [Chromium] Enable AtomicString && CString && WTFString && StringImpl unit tests
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Tools / TestsAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, dominicc, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 94562    
Bug Blocks:    
Attachments:
Description Flags
Proposed change: enable CString on Chromium and fix the debug build.
none
Better proposed change: enable all the Strings unit tests \o/
none
Patch for the EWS / landing. none

Description Julien Chaffraix 2012-08-23 16:50:52 PDT 
Bug 94562 landed without enabling the CString test for Chromium due to some failures on the EWS.

I tried to reproduce the failures but couldn't, which matches Benjamin's experience. I did find a build breakage though related to the #include chain (not sure why no other platform complained).

Let's fix Chromium and add this test!
Comment 1 Benjamin Poulain 2012-08-23 16:57:45 PDT 
The other String tests were also skipped on Chromium, let's enable everything if possible.
Comment 2 Julien Chaffraix 2012-08-23 17:03:49 PDT 
Created attachment 160284 [details]
Proposed change: enable CString on Chromium and fix the debug build.
Comment 3 Julien Chaffraix 2012-08-23 17:04:17 PDT 
Comment on attachment 160284 [details]
Proposed change: enable CString on Chromium and fix the debug build.

OK, let's do it.
Comment 4 Julien Chaffraix 2012-08-23 17:40:19 PDT 
Created attachment 160294 [details]
Better proposed change: enable all the Strings unit tests \o/
Comment 5 Benjamin Poulain 2012-08-23 17:45:08 PDT 
Comment on attachment 160294 [details]
Better proposed change: enable all the Strings unit tests \o/

Thanks a lot for finding the problem.
Comment 6 Benjamin Poulain 2012-08-23 17:58:02 PDT 
Comment on attachment 160294 [details]
Better proposed change: enable all the Strings unit tests \o/

Looks like r126509 got in the way :(
Comment 7 Julien Chaffraix 2012-08-23 18:19:18 PDT 
Created attachment 160302 [details]
Patch for the EWS / landing.
Comment 8 WebKit Review Bot 2012-08-23 20:02:48 PDT 
Comment on attachment 160302 [details]
Patch for the EWS / landing.

Clearing flags on attachment: 160302

Committed r126530: <http://trac.webkit.org/changeset/126530>
Comment 9 WebKit Review Bot 2012-08-23 20:02:51 PDT 
All reviewed patches have been landed.  Closing bug.