Bug 94857

Summary: Remove unnecessary CSS selector text generation
Product: WebKit Reporter: Tony Chang <tony>
Component: CSSAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dglazkov, kling, koivisto, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from gce-cr-linux-06
none
Patch none

Tony Chang
Reported 2012-08-23 14:35:53 PDT
Remove unnecessary CSS selector text generation
Attachments
Patch (2.26 KB, patch)
2012-08-23 14:38 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-06 (542.33 KB, application/zip)
2012-08-23 16:30 PDT, WebKit Review Bot 		no flags
Details
Patch (2.50 KB, patch)
2012-08-23 16:41 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-08-23 14:38:56 PDT
Created attachment 160252 [details] Patch
Tony Chang
Comment 2 2012-08-23 14:41:28 PDT
It looks like we added the selector text cache in http://trac.webkit.org/changeset/102584 , and in http://trac.webkit.org/changeset/113099 , we removed the code using oldSelectorText, but not the code to generate oldSelectorText.
WebKit Review Bot
Comment 3 2012-08-23 16:30:51 PDT
Comment on attachment 160252 [details] Patch Attachment 160252 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13558940 New failing tests: http/tests/inspector/modify-cross-domain-rule.html inspector/styles/commit-selector.html inspector/styles/add-new-rule-inline-style-csp.html inspector/styles/styles-new-API.html inspector/styles/undo-set-selector-text.html
WebKit Review Bot
Comment 4 2012-08-23 16:30:54 PDT
Created attachment 160276 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Tony Chang
Comment 5 2012-08-23 16:34:42 PDT
Comment on attachment 160252 [details] Patch Hmm, those failures look real. Investigating.
Tony Chang
Comment 6 2012-08-23 16:41:26 PDT
Created attachment 160279 [details] Patch
WebKit Review Bot
Comment 7 2012-08-24 12:15:10 PDT
Comment on attachment 160279 [details] Patch Clearing flags on attachment: 160279 Committed r126610: <http://trac.webkit.org/changeset/126610>
WebKit Review Bot
Comment 8 2012-08-24 12:15:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.