Bug 94853

Summary:

[GTK] Compiling with --disable-javascript-debugger fails with undefined symbol

Product:

WebKit

Reporter:

Philip Chimento <philip.chimento>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Minor

CC:

eric, pfeldman, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.6

Attachments:

Description	Flags
Patch that fixes the problem	eric: review-

Philip Chimento

Reported 2012-08-23 14:22:20 PDT

Created attachment 160244 [details] Patch that fixes the problem Configuring with --disable-javascript-debugger causes make to fail with an undefined symbol. Here is a patch (based on WebKitGTK 1.8.3) that fixes it.

Attachments
Patch that fixes the problem (2.44 KB, patch) 2012-08-23 14:22 PDT, Philip Chimento	eric: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

WebKit Review Bot

Comment 1 2012-08-23 14:24:09 PDT

Attachment 160244 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Seidel (no email)

Comment 2 2012-08-27 13:40:52 PDT

Comment on attachment 160244 [details] Patch that fixes the problem Needs a ChangeLog. I'm not 100% convinced these are the right #define points. I assume ScriptProfiler is only compiled in for debugger-enabled builds? And what part of addInspectedheapObject fails?

Philip Chimento

Comment 3 2015-01-02 20:24:20 PST

I don't believe this is a problem anymore.

Note You need to log in before you can comment on or make changes to this bug.