Bug 94838

Summary: Make things build with the latest version of clang
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: WebKit Misc.Assignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, eric.carlson, feature-media-reviews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WTF
mitz: review+
JavaScriptCore
mitz: review+
WebCore
mitz: review+
WebKit2
mitz: review+
gtest mitz: review+

Mark Rowe (bdash)
Reported 2012-08-23 13:04:25 PDT
As it says in the summary.
Attachments
WTF (3.55 KB, patch)
2012-08-23 13:05 PDT, Mark Rowe (bdash) 		mitz: review+
DetailsFormatted DiffDiff
JavaScriptCore (5.57 KB, patch)
2012-08-23 13:05 PDT, Mark Rowe (bdash) 		mitz: review+
DetailsFormatted DiffDiff
WebCore (7.92 KB, patch)
2012-08-23 13:06 PDT, Mark Rowe (bdash) 		mitz: review+
DetailsFormatted DiffDiff
WebKit2 (2.42 KB, patch)
2012-08-23 13:06 PDT, Mark Rowe (bdash) 		mitz: review+
DetailsFormatted DiffDiff
gtest (1.50 KB, patch)
2012-08-23 13:07 PDT, Mark Rowe (bdash) 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2012-08-23 13:05:28 PDT
Created attachment 160222 [details] WTF
Mark Rowe (bdash)
Comment 2 2012-08-23 13:05:51 PDT
Created attachment 160223 [details] JavaScriptCore
Mark Rowe (bdash)
Comment 3 2012-08-23 13:06:22 PDT
Created attachment 160224 [details] WebCore
Mark Rowe (bdash)
Comment 4 2012-08-23 13:06:42 PDT
Created attachment 160225 [details] WebKit2
Mark Rowe (bdash)
Comment 5 2012-08-23 13:07:03 PDT
Created attachment 160226 [details] gtest
WebKit Review Bot
Comment 6 2012-08-23 13:08:44 PDT
Attachment 160222 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Fa..." exit_code: 1 Source/WTF/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 7 2012-08-23 13:09:46 PDT
Attachment 160223 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 8 2012-08-23 13:10:52 PDT
Attachment 160224 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 9 2012-08-23 13:11:55 PDT
Attachment 160225 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 10 2012-08-23 13:14:02 PDT
Attachment 160226 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ChangeLog', u'Source/Thi..." exit_code: 1 Source/ThirdParty/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Rowe (bdash)
Comment 11 2012-08-23 13:57:24 PDT
I landed these in r126475 - r126479.
Note You need to log in before you can comment on or make changes to this bug.