Bug 94814

Summary: Make it possible to build WebKit with Python 3 (and 2)
Product: WebKit Reporter: Frederik Gladhorn <gladhorn>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, hausmann, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 94907, 94910    
Bug Blocks:    
Attachments:
Description Flags
Patch rniwa: review+

Frederik Gladhorn
Reported 2012-08-23 07:46:38 PDT
Build Qt port with Python 3 (and 2)
Attachments
Patch (11.15 KB, patch)
2012-08-23 07:49 PDT, Frederik Gladhorn 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frederik Gladhorn
Comment 1 2012-08-23 07:49:42 PDT
Created attachment 160162 [details] Patch
Simon Hausmann
Comment 2 2012-08-23 13:46:20 PDT
CCing some Python gurus :) EWS seems optimistic that this doesn't break at least the python2 based builds.
Ryosuke Niwa
Comment 3 2012-08-23 13:58:28 PDT
Comment on attachment 160162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160162&action=review > Source/WebCore/inspector/CodeGeneratorInspector.py:90 > + import sys I think we'd rather import this at the beginning of the file.
Ryosuke Niwa
Comment 4 2012-08-23 14:43:30 PDT
If you're not a committer yet, then please ask someone to land it on behalf of you or set cq? flag.
Simon Hausmann
Comment 5 2012-08-23 22:21:49 PDT
Comment on attachment 160162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160162&action=review I can take care of the landing (and will remove the Qt part in ChangeLog) >> Source/WebCore/inspector/CodeGeneratorInspector.py:90 >> + import sys > > I think we'd rather import this at the beginning of the file. Seems indeed strange in the presence of "import sys" in line 32.
Simon Hausmann
Comment 6 2012-08-23 22:37:54 PDT
Committed r126542: <http://trac.webkit.org/changeset/126542>
Mark Rowe (bdash)
Comment 7 2012-08-23 23:30:14 PDT
This change breaks building projects dependent on WebKit2 on OS X. messages.py and parser.py live alongside each other inside WebKit2.framework on OS X, and there is no "webkit2" module to import them from. Can you please either revert that part of this change, or make other changes that will allow "import parser" to succeed?
WebKit Review Bot
Comment 8 2012-08-23 23:38:18 PDT
Re-opened since this is blocked by 94907
Mark Rowe (bdash)
Comment 9 2012-08-24 00:23:42 PDT
Bug 94910 has a simple patch that, when landed, will allow this patch to be landed without breaking anything on OS X.
Mark Rowe (bdash)
Comment 10 2012-08-24 00:41:01 PDT
That patch is now landed. Feel free to reland this patch as it will no longer break us on OS X!
Simon Hausmann
Comment 11 2012-08-24 01:39:20 PDT
(In reply to comment #10) > That patch is now landed. Feel free to reland this patch as it will no longer break us on OS X! Wonderful, thanks! Will reland.
Simon Hausmann
Comment 12 2012-08-24 01:44:10 PDT
Committed r126558: <http://trac.webkit.org/changeset/126558>
Note You need to log in before you can comment on or make changes to this bug.