| Summary: | Make it possible to build WebKit with Python 3 (and 2) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Frederik Gladhorn <gladhorn> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dpranke, hausmann, rniwa, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 94907, 94910 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Frederik Gladhorn
2012-08-23 07:46:38 PDT
Created attachment 160162 [details]
Patch
CCing some Python gurus :) EWS seems optimistic that this doesn't break at least the python2 based builds. Comment on attachment 160162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160162&action=review > Source/WebCore/inspector/CodeGeneratorInspector.py:90 > + import sys I think we'd rather import this at the beginning of the file. If you're not a committer yet, then please ask someone to land it on behalf of you or set cq? flag. Comment on attachment 160162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160162&action=review I can take care of the landing (and will remove the Qt part in ChangeLog) >> Source/WebCore/inspector/CodeGeneratorInspector.py:90 >> + import sys > > I think we'd rather import this at the beginning of the file. Seems indeed strange in the presence of "import sys" in line 32. Committed r126542: <http://trac.webkit.org/changeset/126542> This change breaks building projects dependent on WebKit2 on OS X. messages.py and parser.py live alongside each other inside WebKit2.framework on OS X, and there is no "webkit2" module to import them from. Can you please either revert that part of this change, or make other changes that will allow "import parser" to succeed? Re-opened since this is blocked by 94907 Bug 94910 has a simple patch that, when landed, will allow this patch to be landed without breaking anything on OS X. That patch is now landed. Feel free to reland this patch as it will no longer break us on OS X! (In reply to comment #10) > That patch is now landed. Feel free to reland this patch as it will no longer break us on OS X! Wonderful, thanks! Will reland. Committed r126558: <http://trac.webkit.org/changeset/126558> |