Bug 94811

Summary: Remove redundant check for negative values when using WebCore::Color::alpha()
Product: WebKit Reporter: Bruno Abinader (history only) <bruno.abinader>
Component: Layout and RenderingAssignee: Bruno Abinader (history only) <bruno.abinader>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, igor.oliveira, kling, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Bruno Abinader (history only)
Reported 2012-08-23 07:27:26 PDT
Though alpha() returns a signed value (int), its value is stored on an unsigned typedef (RGBA32) and is safeguarded by alphaChannel() that its value never goes beyond 255, so no integer overflow, thus we can safely remove redundant check for negative values while using it.
Attachments
Patch (5.25 KB, patch)
2012-08-23 07:32 PDT, Bruno Abinader (history only) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bruno Abinader (history only)
Comment 1 2012-08-23 07:32:35 PDT
Created attachment 160158 [details] Patch Proposed patch.
Eric Seidel (no email)
Comment 2 2012-08-23 11:00:23 PDT
Comment on attachment 160158 [details] Patch OK.
WebKit Review Bot
Comment 3 2012-08-23 11:28:00 PDT
Comment on attachment 160158 [details] Patch Clearing flags on attachment: 160158 Committed r126452: <http://trac.webkit.org/changeset/126452>
WebKit Review Bot
Comment 4 2012-08-23 11:28:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.