Summary: | Flexbox doesn't need to compute logical height for stretched items in row flow | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shezan Baig <shezbaig.wk> | ||||||
Component: | Layout and Rendering | Assignee: | Shezan Baig <shezbaig.wk> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, ojan, tony, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Shezan Baig
2012-08-23 06:53:30 PDT
Created attachment 160173 [details]
Patch
Initial patch for review
Comment on attachment 160173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160173&action=review > Source/WebCore/rendering/RenderBox.cpp:443 > if (maxH == -1) > - maxH = result; > - result = min(maxH, result); > - result = max(minH, result); > - return result; > + maxH = logicalHeight; > + logicalHeight = min(maxH, logicalHeight); Nit: This could just be: if (maxH != -1) logicalHeight = min(maxH, logicalHeight); Created attachment 160205 [details]
Patch
I simplified it further -- the entire maxH block can be skipped if style()->logicalMaxHeight().isUndefined()
Comment on attachment 160205 [details] Patch Clearing flags on attachment: 160205 Committed r126468: <http://trac.webkit.org/changeset/126468> All reviewed patches have been landed. Closing bug. |