Summary: | successCallback of ResolveLocalFileSystemURL should not be optional. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Taiju Tsuiki <tzik> | ||||||||||||
Component: | WebKit Misc. | Assignee: | Taiju Tsuiki <tzik> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | abarth, dglazkov, ericu, kinuko, ojan, tkent, webkit.review.bot | ||||||||||||
Priority: | P2 | Keywords: | WebExposed | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Taiju Tsuiki
2012-08-23 05:52:23 PDT
Created attachment 160140 [details]
Patch
Comment on attachment 160140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160140&action=review > Source/WebCore/ChangeLog:5 > + Please add a link to the spec and description why we need to remove optional flag. Comment on attachment 160140 [details] Patch Attachment 160140 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13561709 New failing tests: fast/filesystem/filesystem-no-callback-null-ptr-crash.html Created attachment 160148 [details]
Archive of layout-test-results from gce-cr-linux-04
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 160149 [details]
Patch
Comment on attachment 160140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160140&action=review >> Source/WebCore/ChangeLog:5 >> + > > Please add a link to the spec and description why we need to remove optional flag. Done Comment on attachment 160149 [details] Patch Attachment 160149 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13565727 New failing tests: fast/filesystem/filesystem-no-callback-null-ptr-crash.html Created attachment 160156 [details]
Archive of layout-test-results from gce-cr-linux-07
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment on attachment 160149 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160149&action=review > LayoutTests/ChangeLog:11 > + * fast/filesystem/filesystem-no-callback-null-ptr-crash.html: This test is for a crash with a particular scenario. We should have another conformance test for existence of the successCallback argument. > LayoutTests/fast/filesystem/filesystem-no-callback-null-ptr-crash.html:19 > - webkitResolveLocalFileSystemURL(''); > try { > - webkitRequestFileSystem(TEMPORARY, 100); > - } > + webkitResolveLocalFileSystemURL(''); > catch(e) { > - document.getElementById('log').innerHTML = "PASS"; > + try { > + webkitRequestFileSystem(TEMPORARY, 100); > + } > + catch(e) { > + document.getElementById('log').innerHTML = "PASS"; > + } This looks to change the testing scenario. Created attachment 160337 [details]
Patch
Comment on attachment 160149 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160149&action=review >> LayoutTests/ChangeLog:11 >> + * fast/filesystem/filesystem-no-callback-null-ptr-crash.html: > > This test is for a crash with a particular scenario. We should have another conformance test for existence of the successCallback argument. Done >> LayoutTests/fast/filesystem/filesystem-no-callback-null-ptr-crash.html:19 >> + } > > This looks to change the testing scenario. I see. Reverted. Comment on attachment 160337 [details]
Patch
Looks ok.
Comment on attachment 160337 [details] Patch Clearing flags on attachment: 160337 Committed r128018: <http://trac.webkit.org/changeset/128018> All reviewed patches have been landed. Closing bug. |