Bug 9479

Summary:

Disassociate the inspector from the frame when it detaches from its parent

Product:

WebKit

Reporter:

mitz

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

timothy

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Proposed patch	timothy: review+

mitz

Reported 2006-06-17 01:37:07 PDT

[This is a follow-up to bug 8672] The current way of the Inspector observing NSWindowWillCloseNotification in order to tell when to disassociate from the inspected WebFrame is wrong. Aside from the fact that it doesn't track the WebFrame's WebView's window and hostWindow as they change, a WebFrame can be deallocated while its WebView remains in a window. For example, this crashes Safari (which is why this bug is P1): 1. Open a frameset page. 2. Inspect an element in one of the frames. 3. Navigate to another page in the same tab. 4. Try to select a different node in the inspector.

Attachments
Proposed patch (6.36 KB, patch) 2006-06-17 01:46 PDT, mitz	timothy: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2006-06-17 01:46:31 PDT

Created attachment 8877 [details] Proposed patch

mitz

Comment 2 2006-06-17 01:54:10 PDT

Comment on attachment 8877 [details] Proposed patch The same idea can be implemented with generic notifications, which may be cleaner (since WebFrame wouldn't need to know about inspectors).

Geoffrey Garen

Comment 3 2006-06-17 20:43:59 PDT

Notification sure sounds better to me. TimH?

Timothy Hatcher

Comment 4 2006-06-17 21:01:43 PDT

Comment on attachment 8877 [details] Proposed patch r=me. A WebFrame might need to know about it's inspectors in the future, so this is fine.

David Kilzer (:ddkilzer)

Comment 5 2006-06-18 10:56:32 PDT

Committed revision 14906.

Note You need to log in before you can comment on or make changes to this bug.