Summary: | [V8] SharedPersistent isn't needed---let's delete it | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, eric, haraken, japhet, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Adam Barth
2012-08-22 19:04:52 PDT
Created attachment 160062 [details]
builds but not tested
Comment on attachment 160062 [details] builds but not tested View in context: https://bugs.webkit.org/attachment.cgi?id=160062&action=review > Source/WebCore/ChangeLog:9 > + The New/Dispose mechanism already does that for us. We can use use Nit: use use => use Comment on attachment 160062 [details]
builds but not tested
I makes a crash.
I'm not exactly sure what's causing these crashes. Note: The patch has a memory leak because we need to add an "adopt" method to OwnHandle so that we don't call Persistent::New an extra time for the handle returned by createNewContext. This has been fixed (by removing V8). |