Bug 94766

Summary:

[V8] SharedPersistent isn't needed---let's delete it

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, eric, haraken, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
builds but not tested	abarth: review-

Description Adam Barth 2012-08-22 19:04:52 PDT

[V8] SharedPersistent isn't needed---let's delete it

Comment 1 Adam Barth 2012-08-22 19:06:51 PDT

Created attachment 160062 [details]
builds but not tested

Comment 2 Kentaro Hara 2012-08-22 19:11:45 PDT

Comment on attachment 160062 [details]
builds but not tested

View in context: https://bugs.webkit.org/attachment.cgi?id=160062&action=review

> Source/WebCore/ChangeLog:9
> +        The New/Dispose mechanism already does that for us. We can use use

Nit: use use => use

Comment 3 Adam Barth 2012-08-22 20:01:04 PDT

Comment on attachment 160062 [details]
builds but not tested

I makes a crash.

Comment 4 Adam Barth 2012-08-22 23:41:08 PDT

I'm not exactly sure what's causing these crashes.  Note: The patch has a memory leak because we need to add an "adopt" method to OwnHandle so that we don't call Persistent::New an extra time for the handle returned by createNewContext.

Comment 5 Anders Carlsson 2013-05-02 11:25:50 PDT

This has been fixed (by removing V8).