Bug 94738 – Use closure compiler to compile blackberry inspector frontend

• Component: WebKit BlackBerry
• Status: RESOLVED INVALID

[Hanna]

Use closure compiler to compile blackberry inspector frontend

first inspectorBB.html should be generated automatically,
then the closure compiler should remove the whitespace within the inspector javascript file

[Hanna]

Created attachment 159986 [details]
Patch

[Pavel Feldman]

Inspector now loads code lazily using module infrastructure. You should combine files into modules using inline script and deploy all module js files along with inspector.js. See WebCore.gypi (or project.xcodeproj's Streamline inspector blah target) for modules content.

For example you should deploy ElementsPanel.js and inline all the files it imports via importScript. Same goes for other panels.

[Hanna]

(In reply to comment #2)
> Inspector now loads code lazily using module infrastructure. You should combine files into modules using inline script and deploy all module js files along with inspector.js. See WebCore.gypi (or project.xcodeproj's Streamline inspector blah target) for modules content.
> 
> For example you should deploy ElementsPanel.js and inline all the files it imports via importScript. Same goes for other panels.

I looked at WebCore.gypi, it puts all the inspector frontend file names in 'webinspector_files'? I do not get what it's supposed to tell me.

So if ElementsPanel.js uses variable WebInspector, then I should say importScript(inspector.js) so that it knows the variable WebInspector on its own? What am I supposed to do with the modules afterwards? combining them together?

[Pavel Feldman]

Look at the streamline inspector resources target in xcode project for WebCore and do the same thing. (Or extract it and reuse in both).

[Hanna]

(In reply to comment #4)
> Look at the streamline inspector resources target in xcode project for WebCore and do the same thing. (Or extract it and reuse in both).

the streamline inspector in xcode proj combines all the js files except for a few worker files and 'import script' in those worker files imports things that they need? In our case we copy them over seperately, this setup only applies to the combined inspector files

[Pavel Feldman]

> the streamline inspector in xcode proj combines all the js files except for a few worker files and 'import script' in those worker files imports things that they need? In our case we copy them over seperately, this setup only applies to the combined inspector files

I think you are looking at the outdated version of that file (> 2 weeks old).

[Rob Buis]

Comment on attachment 159986 [details]
Patch

R- based on Pavel's comment.

[Rob Buis]

Peter, is this something for you to look at? Konrad is on vacation.