Bug 94730 – Layout Test fast/repaint/japanese-rl-selection-repaint-in-regions.html is failing after r126304

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Kenneth Russell]

The following layout test is failing on Chromium Mac:

fast/repaint/japanese-rl-selection-repaint-in-regions.html

It looks like it started failing with different image results after http://trac.webkit.org/changeset/126304/ . See:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Frepaint%2Fjapanese-rl-selection-repaint-in-regions.html

and look specifically at the Webkit Mac10.6, Webkit Mac10.7 and Webkit Mac10.7 (dbg) image results. (The other platforms were expected to have differences.)

From reading the description of the above changeset it doesn't sound like it was supposed to affect rendering at all, only correctness, so I think this change in behavior warrants investigation.

Not seeing failures on the Apple bots on build.webkit.org, interestingly.

I'm going to mark this as an expected failure in LayoutTests/platform/chromium/TestExpectations for the moment.

[Kenneth Russell]

Committed r126322: <http://trac.webkit.org/changeset/126322>

[Andrei Bucur]

Created attachment 161005 [details]
Patch

[Dave Hyatt]

Comment on attachment 161005 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 161005 [details]
Patch

Rejecting attachment 161005 [details] from commit-queue.

New failing tests:
http/tests/cache/post-with-cached-subresources.php
Full output: http://queues.webkit.org/results/13654451

[WebKit Review Bot]

Created attachment 161020 [details]
Archive of layout-test-results from gce-cq-03

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[WebKit Review Bot]

Comment on attachment 161005 [details]
Patch

Rejecting attachment 161005 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Review Bot]

Comment on attachment 161005 [details]
Patch

Rejecting attachment 161005 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Adam Barth]

Sorry for the noise on this bug.  I'm not sure what's wrong with the bots.  :(

[Adam Barth]

Comment on attachment 161005 [details]
Patch

Re-applying Hyatt's r+

[WebKit Review Bot]

Comment on attachment 161005 [details]
Patch

Clearing flags on attachment: 161005

Committed r126961: <http://trac.webkit.org/changeset/126961>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.