Summary: | Web Inspector: make "sdk" component compile independently from the rest of the front-end. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Pavel Feldman
2012-08-22 06:57:52 PDT
Created attachment 159929 [details]
Patch
Comment on attachment 159929 [details] Patch Attachment 159929 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13562265 Comment on attachment 159929 [details] Patch Attachment 159929 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13571235 Comment on attachment 159929 [details] Patch Attachment 159929 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13564290 Comment on attachment 159929 [details] Patch Attachment 159929 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13566254 Comment on attachment 159929 [details] Patch Attachment 159929 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13568241 New failing tests: inspector/extensions/extensions-resources.html inspector/storage-panel-dom-storage.html inspector/storage-panel-dom-storage-update.html Created attachment 159932 [details]
Archive of layout-test-results from gce-cr-linux-07
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 159938 [details]
Patch
Comment on attachment 159938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159938&action=review > Source/WebCore/inspector/front-end/DOMStorage.js:163 > + payload.isLocalStorage)) ; > Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:-195 > -var InspectorFrontendHost = new WebInspector.InspectorFrontendHostStub(); Why? > Source/WebCore/inspector/front-end/ResourcesPanel.js:366 > + this._showDOMStorage(domStorage); Can we remove it like showDatabase was removed? > Source/WebCore/inspector/front-end/ScriptsPanel.js:395 > + WebInspector.searchController.disableSearchUntilExplicitAction(); Why did this change? Committed r126314: <http://trac.webkit.org/changeset/126314> |