Bug 94700

Summary: webkit-patch gets stuck into an infinite loop if bugzilla doesn't respond in time.
Product: WebKit Reporter: Szilard Ledan <szledan>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, galpeter, kadam, kkristof, ojan, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Szilard Ledan
Reported 2012-08-22 06:29:49 PDT
webkit-patch gets stuck into an infinite loop if bugzilla dosen't respond in time. Interrupting download with a timeout would be a possible solution.
Attachments
patch (2.00 KB, patch)
2012-08-28 08:51 PDT, Szilard Ledan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-08-22 06:31:58 PDT
Fixing it is important, because I have to restart EWS bots regularly because of this bug. It would be better if EWS can handle this situation automatically.
Szilard Ledan
Comment 2 2012-08-28 08:51:46 PDT
Created attachment 160994 [details] patch
Adam Barth
Comment 3 2012-08-28 08:58:11 PDT
Thanks for working on this bug! Eric, would you be willing to review this patch?
Eric Seidel (no email)
Comment 4 2012-08-28 11:06:29 PDT
Comment on attachment 160994 [details] patch SGTM.
WebKit Review Bot
Comment 5 2012-08-28 11:36:18 PDT
Comment on attachment 160994 [details] patch Clearing flags on attachment: 160994 Committed r126905: <http://trac.webkit.org/changeset/126905>
WebKit Review Bot
Comment 6 2012-08-28 11:36:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.