Bug 94658

Summary: [chromium/mac] Remove unnecessary checks for OS version <= 10.5. We don't support those
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, dpranke, playmobil, thakis, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

James Robinson
Reported 2012-08-21 18:07:32 PDT
[chromium/mac] Remove unnecessary checks for OS version <= 10.5. We don't support those
Attachments
Patch (3.52 KB, patch)
2012-08-21 18:08 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-08-21 18:08:28 PDT
Created attachment 159830 [details] Patch
James Robinson
Comment 2 2012-08-21 18:11:07 PDT
There's also a runtime OS X version check in FontMac.mm that we use, but it's checking for a bug only present in Snow Leopard and not in higher versions so we have to check that at runtime. The mac weenies report that it'd be better to use base::mac::IsOSSnowLeopard() since it just uses uname() instead of Gestalt, but we'd have to plumb that through WK API
Nico Weber
Comment 3 2012-08-21 19:00:05 PDT
Comment on attachment 159830 [details] Patch lgtm
Nico Weber
Comment 4 2012-08-21 19:00:24 PDT
Jeremy: FYI
James Robinson
Comment 5 2012-08-22 10:44:36 PDT
Comment on attachment 159830 [details] Patch Thanks Tony!
WebKit Review Bot
Comment 6 2012-08-22 10:56:26 PDT
Comment on attachment 159830 [details] Patch Clearing flags on attachment: 159830 Committed r126320: <http://trac.webkit.org/changeset/126320>
WebKit Review Bot
Comment 7 2012-08-22 10:56:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.