Bug 94653 – IndexedDB: tests for injection/extraction of idb keys

• Component: New Bugs
• Status: RESOLVED FIXED

[Alec Flett]

IndexedDB: tests for injection/extraction of idb keys

[Alec Flett]

Created attachment 159813 [details]
Patch

[Alec Flett]

jsbell/dgrogan- these are ported over from chromium, so we can kill the chromium tests.

[Joshua Bell]

Comment on attachment 159813 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159813&action=review

lgtm

> Source/WebKit/chromium/ChangeLog:8
> +        Added unit tests for key injection/extraction using 

Might want to mention that this is moving a Chromium test here now that the functionality is constrained to WebKit. Otherwise, the test is a little weird since half of it is still just testing the SSV serialization format.

> Source/WebKit/chromium/tests/IDBKeyPathTest.cpp:130
> +#define arraysize(x) (sizeof((x)) / sizeof((x[0])))

Use WTF_ARRAY_LENGTH macro instead?

> Source/WebKit/chromium/tests/IDBKeyPathTest.cpp:171
> +    ssv = SerializedScriptValue::createFromWire(String(data));

This isn't passing the length into String() - what's different here?

[Alec Flett]

Comment on attachment 159813 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159813&action=review

>> Source/WebKit/chromium/tests/IDBKeyPathTest.cpp:130
>> +#define arraysize(x) (sizeof((x)) / sizeof((x[0])))
> 
> Use WTF_ARRAY_LENGTH macro instead?

ah! Knew there must have been something equivalent.

>> Source/WebKit/chromium/tests/IDBKeyPathTest.cpp:171
>> +    ssv = SerializedScriptValue::createFromWire(String(data));
> 
> This isn't passing the length into String() - what's different here?

a bug..fixed.

[Alec Flett]

Created attachment 159999 [details]
Patch

[Alec Flett]

tony@ - this is actually migration of code (chromium->webkit) for the chromium review I just asked about..

[Tony Chang]

Comment on attachment 159999 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159999&action=review

> Source/WebKit/chromium/tests/IDBKeyPathTest.cpp:190
> +    const UChar expectedData[] = {0x01ff, 0x003f, 0x3f6f, 0x5301, 0x6603,
> +                                   0x6f6f, 0x013f, 0x0353, 0x6f7a, 0x3f6f,

Nit: Indent is weird.

> Source/WebKit/chromium/tests/IDBKeyPathTest.cpp:205
> +    const UChar expectedData2[] = {0x01ff, 0x003f, 0x3f6f, 0x5301, 0x6603,
> +                                    0x6f6f, 0x013f, 0x0353, 0x6f7a, 0x3f6f,

Nit: ditto

[Alec Flett]

Created attachment 160037 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 160037 [details]
Patch for landing

Clearing flags on attachment: 160037

Committed r126381: <http://trac.webkit.org/changeset/126381>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.