Bug 94625 – Create CSS color output string on 8 bits

• Component: CSS
• Status: RESOLVED FIXED

[Benjamin Poulain]

Forcing 16 bits on everyone is bad.

[Benjamin Poulain]

Created attachment 159735 [details]
Patch

[Andreas Kling]

Comment on attachment 159735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159735&action=review

r=me

> Source/WebCore/css/CSSPrimitiveValue.cpp:1011
> +            bool colorHasAlpha = color.hasAlpha();

Does this really need a local variable?

> Source/WebCore/css/CSSPrimitiveValue.cpp:1029
> +                NumberToStringBuffer buffer;
> +                const char* alphaString = numberToFixedPrecisionString(color.alpha() / 255.0f, 6, buffer, true);
> +                result.append(alphaString, strlen(alphaString));

Too bad we need the strlen() here.

[Benjamin Poulain]

Comment on attachment 159735 [details]
Patch

Clearing flags on attachment: 159735

Committed r126186: <http://trac.webkit.org/changeset/126186>

[Benjamin Poulain]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Shouldn’t we be doing this with StringBuilder rather than Vector<LChar>?

[Benjamin Poulain]

(In reply to comment #5)
> Shouldn’t we be doing this with StringBuilder rather than Vector<LChar>?

StringBuilder could do the job but it does not anything similar to WTF::appendNumber(). I do not mind updating StringBuilder if you think it is important.