[New Multicolumn] Get column rules painting

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Dave Hyatt]

Get the column rules painting properly in column sets.

[Dave Hyatt]

Created attachment 159721 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 159721 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159721&action=review

> Source/WebCore/ChangeLog:11
> +        No new tests (OOPS!).

OOPS! Are ref tests possible? Would be good to test rule painting with mixed writing modes.

> Source/WebCore/rendering/RenderMultiColumnBlock.h:46
> +    RenderMultiColumnFlowThread* flowThread() const { return m_flowThread; }

Should it return a const RenderMultiColumnFlowThread*?

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:65
> +int RenderMultiColumnSet::columnGap() const

This doesn't need to return a LayoutUnit?

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:69
> +    return static_cast<int>(style()->columnGap());

Maybe use pixelSnap, or make the rounding mode more explicit?

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:72
> +LayoutRect RenderMultiColumnSet::columnRectAt( unsigned index) const

Space after (

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:74
> +    // Compute the appropriate rect based off our information.

Not sure that this comment adds anything.

[Dave Hyatt]

Fixed in r126177.