Summary: | Web Inspector: do not use window's eval in InjectedScript | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, apavlov, bweinstein, haraken, japhet, joepeck, keishi, loislo, mark.lam, mkwst, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys, zarvai | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Pavel Feldman
2012-08-21 09:54:35 PDT
Created attachment 159706 [details]
Patch
Created attachment 159708 [details]
Patch
Committed r126168: <http://trac.webkit.org/changeset/126168> This change broke http/tests/inspector/console-resource-errors.html on mac. See: http://build.webkit.org/results/Apple%20Lion%20Release%20WK2%20(Tests)/r126184%20(2456)/http/tests/inspector/console-resource-errors-pretty-diff.html (In reply to comment #4) > This change broke http/tests/inspector/console-resource-errors.html on mac. See: > http://build.webkit.org/results/Apple%20Lion%20Release%20WK2%20(Tests)/r126184%20(2456)/http/tests/inspector/console-resource-errors-pretty-diff.html Also it fails on EFL and Qt. Rebaseline? Single rebaseline would fix them all. (In reply to comment #6) > Single rebaseline would fix them all. Rebaseline done in r126281 :) |