Summary: | [GTK] Replace webkit_web_view_replace_content with webkit_web_view_load_alternate_html | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gustavo, gyuyoung.kim, mrobinson, webkit.review.bot, xan.lopez | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2012-08-20 05:35:23 PDT
Created attachment 159403 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 159403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159403&action=review Thanks! > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1554 > + * error page, the the back-forward list is maintained appropriately. Hrm. Would it make sense to just say outright something like, "When this method is called, a new entry is added to the back-forward list." ? > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1555 > + * For everything else this method works the same way than webkit_web_view_load_html(). Nit: same way than -> same way as (In reply to comment #3) > (From update of attachment 159403 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159403&action=review > > Thanks! > > > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1554 > > + * error page, the the back-forward list is maintained appropriately. > > Hrm. Would it make sense to just say outright something like, "When this method is called, a new entry is added to the back-forward list." ? It's more complicated than that, when alternate string is called from a load error callback, going back/forward from a load error page convert the load into a reload to avoid a new time to be added to the back forward list. See this bug: https://bugs.webkit.org/show_bug.cgi?id=94476 Because it's currently broken in wk2, and see the implementation here: http://trac.webkit.org/browser/trunk/Source/WebCore/loader/FrameLoader.cpp So, I copied the description from the wk1 mac docs: https://developer.apple.com/library/mac/#documentation/Cocoa/Reference/WebKit/ObjC_classic/_index.html I plan to add a unit test for that case, skipped until bug #94476 is fixed. > > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1555 > > + * For everything else this method works the same way than webkit_web_view_load_html(). > > Nit: same way than -> same way as Ok. Committed r126030: <http://trac.webkit.org/changeset/126030> |