Bug 94464

Summary: [GTK] Provide backwards compatible method for WebKitDOMWebKitNamedFlow::overflow
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Xan Lopez
Reported 2012-08-20 04:42:25 PDT
This was removed from upstream, but we need to keep compatibility to some extent. See https://bugs.webkit.org/show_bug.cgi?id=93477#c2 for more details.
Attachments
Patch (4.05 KB, patch)
2012-08-20 04:45 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2012-08-20 04:45:25 PDT
Created attachment 159394 [details] Patch
WebKit Review Bot
Comment 2 2012-08-20 04:48:38 PDT
Attachment 159394 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/gobject/WebKitDOMCustom.h:38: The parameter name "flow" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 3 2012-08-20 05:21:41 PDT
Comment on attachment 159394 [details] Patch Thanks!
WebKit Review Bot
Comment 4 2012-08-20 05:26:12 PDT
Comment on attachment 159394 [details] Patch Clearing flags on attachment: 159394 Committed r126021: <http://trac.webkit.org/changeset/126021>
WebKit Review Bot
Comment 5 2012-08-20 05:26:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.