Bug 94464

Summary: [GTK] Provide backwards compatible method for WebKitDOMWebKitNamedFlow::overflow
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Xan Lopez 2012-08-20 04:42:25 PDT
This was removed from upstream, but we need to keep compatibility to some extent. See https://bugs.webkit.org/show_bug.cgi?id=93477#c2 for more details.
Comment 1 Xan Lopez 2012-08-20 04:45:25 PDT
Created attachment 159394 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-20 04:48:38 PDT
Attachment 159394 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/bindings/gobject/WebKitDOMCustom.h:38:  The parameter name "flow" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2012-08-20 05:21:41 PDT
Comment on attachment 159394 [details]
Patch

Thanks!
Comment 4 WebKit Review Bot 2012-08-20 05:26:12 PDT
Comment on attachment 159394 [details]
Patch

Clearing flags on attachment: 159394

Committed r126021: <http://trac.webkit.org/changeset/126021>
Comment 5 WebKit Review Bot 2012-08-20 05:26:15 PDT
All reviewed patches have been landed.  Closing bug.