Bug 94463

Summary: [V8] Increment the amount of externally allocated memory for the receiving V8 isolate when transferring ArrayBuffer
Product: WebKit Reporter: Ulan Degenbaev <ulan>
Component: WebCore JavaScriptAssignee: Ulan Degenbaev <ulan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 92993    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Ulan Degenbaev
Reported 2012-08-20 04:04:06 PDT
Currently we decrease the amount of externally allocated memory for the sending V8 isolate (see bug 92993) but do not increment it for the receiving V8 isolate when transferring array buffers.
Attachments
Patch (4.90 KB, patch)
2012-11-15 04:53 PST, Ulan Degenbaev 		no flags
DetailsFormatted DiffDiff
Patch (4.92 KB, patch)
2012-11-15 05:45 PST, Ulan Degenbaev 		no flags
DetailsFormatted DiffDiff
Patch (4.86 KB, patch)
2012-11-16 04:32 PST, Ulan Degenbaev 		no flags
DetailsFormatted DiffDiff
Patch (4.91 KB, patch)
2012-11-16 04:36 PST, Ulan Degenbaev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ulan Degenbaev
Comment 1 2012-11-15 04:53:49 PST
Created attachment 174406 [details] Patch
Ulan Degenbaev
Comment 2 2012-11-15 04:54:49 PST
Ken, could you please take a look?
Ulan Degenbaev
Comment 3 2012-11-15 05:45:01 PST
Created attachment 174414 [details] Patch
Kenneth Russell
Comment 4 2012-11-15 19:00:12 PST
Comment on attachment 174414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174414&action=review Looks good; r=me. You'll need to submit another patch for this to make it through the commit queue though. > Source/WebCore/ChangeLog:10 > + No new tests (OOPS!). The patch won't pass the commit queue with this OOPS line.
Ulan Degenbaev
Comment 5 2012-11-16 04:32:39 PST
Created attachment 174644 [details] Patch
Kentaro Hara
Comment 6 2012-11-16 04:33:50 PST
Comment on attachment 174644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174644&action=review > Source/WebCore/ChangeLog:9 > + You can write: Test: ManualTests/typed-array-memory.html
Ulan Degenbaev
Comment 7 2012-11-16 04:36:46 PST
Created attachment 174645 [details] Patch
Ulan Degenbaev
Comment 8 2012-11-16 04:37:31 PST
Thanks, Ken and Kentaro! I uploaded new patch set.
WebKit Review Bot
Comment 9 2012-11-16 05:20:32 PST
Comment on attachment 174645 [details] Patch Clearing flags on attachment: 174645 Committed r134934: <http://trac.webkit.org/changeset/134934>
WebKit Review Bot
Comment 10 2012-11-16 05:20:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.