Bug 94454

Summary: media/media-document-audio-repaint.html is racy
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, fischman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Philippe Normand
Reported 2012-08-20 01:32:43 PDT
In the GTK port, sometimes the play event is not catched by the test, playback continues until EOS instead of pausing, doing a seek near the end and ending the test. This triggers a small text diff on the controls: text run at (0,0) width 55: "00:01 / 00:01" instead of text run at (0,0) width 55: "00:00 / 00:01" I think we can safely directly pause the media element from the beginning instead of attempting to play the already playing media. What do you think Ami?
Attachments
Patch (2.22 KB, patch)
2012-08-20 01:50 PDT, Philippe Normand 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2012-08-20 01:50:50 PDT
Created attachment 159367 [details] Patch
Eric Carlson
Comment 2 2012-08-20 06:52:49 PDT
Seems reasonable to me, but lets wait for Ami to have a look.
Ami Fischman
Comment 3 2012-08-20 21:15:53 PDT
Comment on attachment 159367 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159367&action=review LGTM % nit > LayoutTests/ChangeLog:9 > + event. Trigger the display and seek upon reception of the pause event. s/reception/receipt/
Philippe Normand
Comment 4 2012-08-20 23:31:45 PDT
Thank you Ami! I can fix this mistake when landing.
Philippe Normand
Comment 5 2012-08-21 08:15:22 PDT
Committed r126158: <http://trac.webkit.org/changeset/126158>
Note You need to log in before you can comment on or make changes to this bug.