| Summary: | [V8] Remove V8Proxy from V8IsolatedContext | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||
| Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, japhet, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 85330 | ||||||
| Attachments: |
|
||||||
|
Description
Kentaro Hara
2012-08-20 01:06:14 PDT
Created attachment 159352 [details]
Patch
Comment on attachment 159352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159352&action=review > Source/WebCore/bindings/v8/ScriptController.cpp:198 > + isolatedContext = new V8IsolatedContext(m_frame, extensionGroup, worldID); Should V8IsolatedContext be a RefPtr? If so, I'll write a follow-up fix to make it reference-countable. Comment on attachment 159352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159352&action=review >> Source/WebCore/bindings/v8/ScriptController.cpp:198 >> - isolatedContext = new V8IsolatedContext(proxy(), extensionGroup, worldID); >> + isolatedContext = new V8IsolatedContext(m_frame, extensionGroup, worldID); > > Should V8IsolatedContext be a RefPtr? If so, I'll write a follow-up fix to make it reference-countable. Its lifetime is managed by the V8 garbage collector. If you see a clean way to do that with RefPtr, go for it. Comment on attachment 159352 [details] Patch Rejecting attachment 159352 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: eeded at 1 with fuzz 3. patching file Source/WebCore/bindings/v8/ScriptController.cpp patching file Source/WebCore/bindings/v8/V8IsolatedContext.cpp Hunk #2 FAILED at 64. 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/bindings/v8/V8IsolatedContext.cpp.rej patching file Source/WebCore/bindings/v8/V8IsolatedContext.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13543490 Committed r126096: <http://trac.webkit.org/changeset/126096> |