|Summary:||Netscape Plugin (Flash) NSURLRequests have no MainDocumentURL set|
|Product:||WebKit||Reporter:||Rachael Worthington (cheers) <rachael>|
|Component:||Plug-ins||Assignee:||Rachael Worthington (cheers) <rachael>|
|Severity:||Normal||CC:||ap, beidson, ggaren, mitz, opendarwin|
|OS:||OS X 10.4|
Description Rachael Worthington (cheers) 2006-06-14 17:02:03 PDT
Problem seen with Flash plugin requests specifically
Comment 1 Alexey Proskuryakov 2006-11-29 12:02:38 PST
From IRC: Omni is using mainDocumentURL to block specific requests, to "do things like add ".swf" to your blacklist and have flash just not-load, and then click to load it if you want it."
Comment 2 Rachael Worthington (cheers) 2006-11-29 20:23:42 PST
Created attachment 11676 [details] Omni's Fix for this bug ap: here's the change Omni made, to ensure that requests that originate from WebPlugins have their MainDocumentURL set. We use this to decide whether or not to block content.
Comment 3 Alexey Proskuryakov 2006-12-04 22:46:17 PST
Something that surprises me is that this code doesn't seem to be reachable from Netscape-style plugins - the modified method is a WebPluginController API, and the only place in WebKit where it is called is from an SPI of same class ("For compatibility only").
Comment 4 Maciej Stachowiak 2006-12-09 14:47:32 PST
Comment on attachment 11676 [details] Omni's Fix for this bug This may not cover all the right places to get plugins to set a main document URL, but seems like an improvement in any case. r=me
Comment 5 Alexey Proskuryakov 2006-12-10 02:46:46 PST
I'll land this, but would like to clarify something over IRC first.
Comment 6 Alexey Proskuryakov 2006-12-11 11:55:06 PST
Looks like my concerns may be not entirely nonsense - reassigning back to Rachael to look into them some more. Besides this patch being for another issue, I'm not sure if it's even correct to set mainDocumentURL rather than referer here.
Comment 7 David Kilzer (:ddkilzer) 2006-12-28 15:32:19 PST
Comment on attachment 11676 [details] Omni's Fix for this bug Clearing mjs r+ on Attachment 11676 [details] per Comment #6.