Summary: | fast/writing-mode/vertical-baseline-alignment.html has wrong expected png | ||
---|---|---|---|
Product: | WebKit | Reporter: | Koji Ishii <kojii> |
Component: | Text | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | itshustletime, rego |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=196139 | ||
Bug Depends on: | 51450 | ||
Bug Blocks: |
Description
Koji Ishii
2012-08-17 21:00:24 PDT
After discussed with fantasai, I removed [chromium] prefix from the summary. It was found originally during the fix for bug 51450 where Chromium aligned Japanese text with English text using baseline, but then the expected image for Mac: http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/fast/writing-mode/vertical-baseline-alignment-expected.png turned out to be wrong in terms of "SHOULD NOT BE CENTERED" span should actually be centered according to the spec. The current code has two issues: 1. It changes alignment by fonts; Chromium Win issue went away by applying "MS Gothic". The spec defines dominant baseline is central in vertical flow regardless of the font. 2. Even Latin inlines should be centered when dominant baseline is central. The expected image above is wrong in this regard. #2 might look strange to Latin users, but Latin vertical flow should use text-orientation:sideways, which makes dominant baseline to alphabetic as per spec: http://dev.w3.org/csswg/css3-writing-modes/#text-baselines (In reply to Koji Ishii from comment #1) > 2. Even Latin inlines should be centered when dominant baseline is central. > The expected image above is wrong in this regard. > > #2 might look strange to Latin users, but Latin vertical flow should use > text-orientation:sideways, which makes dominant baseline to alphabetic as > per spec: > http://dev.w3.org/csswg/css3-writing-modes/#text-baselines This is somehow related to the lack of support for "text-orientation: sideways", see bug #196139. |