| Summary: | canvas.context.drawImage() should draw SVG at the correct scale. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philip Rogers <pdr> | ||||||||||
| Component: | SVG | Assignee: | Philip Rogers <pdr> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | japhet, simon.fraser, thorton, webkit.review.bot, zimmermann | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 420+ | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 93772 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 159199 [details]
Canvas drawImage() should draw SVG at the correct scale.
Created attachment 159214 [details]
Minor cleanup of test--removed spurious setTimeout.
Adding some people who know this area really well. Comment on attachment 159214 [details] Minor cleanup of test--removed spurious setTimeout. View in context: https://bugs.webkit.org/attachment.cgi?id=159214&action=review This seems right to me! > Source/WebCore/ChangeLog:8 > + After this patch, we now take incorporate the page scale in Grammar ("take incorporate"). Created attachment 159515 [details]
Fix grammar mistake
Thanks for the quick review.
Comment on attachment 159515 [details] Fix grammar mistake Rejecting attachment 159515 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Timothy Horton found in /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13548148 Created attachment 159525 [details]
Fix reviewer's name.
Comment on attachment 159525 [details] Fix reviewer's name. Clearing flags on attachment: 159525 Committed r126094: <http://trac.webkit.org/changeset/126094> All reviewed patches have been landed. Closing bug. |
This is the first bug from wkbug.com/93772. Using drawImage() with an SVG image will incorrectly scale the image as SVG is scaled up for hi resolution displays ("retina", "hidpi") but canvas does not take this into account. Patch forthcoming.