Summary: | [WK2] Get rid of WebContext::m_pendingMessagesToPostToInjectedBundle | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
Component: | WebKit2 | Assignee: | Alexey Proskuryakov <ap> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, jberlin, sam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 98210 | ||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2012-08-17 11:21:51 PDT
Created attachment 159165 [details]
proposed patch
Comment on attachment 159165 [details]
proposed patch
Some things to consider:
- Perhaps injectedBundleInitializationUserData should be sent before all other queued process messages. If we rely on process proxy queueing, that could result in some injected bundle messages being sent before injected bundle initialization.
- If we drop any messages on the floor, consider returning a boolean from postMessageToInjectedBundle().
> - Perhaps injectedBundleInitializationUserData should be sent before all other queued process messages. If we rely on process proxy queueing, that could result in some injected bundle messages being sent before injected bundle initialization. WebProcessProxy::sendMessage only does queueing when the process is launching, so WebProcess::InitializeWebProcess is always the first message already, and it carries injectedBundleInitializationUserData. > - If we drop any messages on the floor, consider returning a boolean from postMessageToInjectedBundle(). I think that if we're to do something like this, it should be done separately, in a fix that has known observable effect. Just returning false would not be terribly helpful, because that wouldn't tell the caller how many of the processes were offline. Created attachment 165701 [details]
Patch updated to ToT
Comment on attachment 165701 [details] Patch updated to ToT View in context: https://bugs.webkit.org/attachment.cgi?id=165701&action=review > Source/WebKit2/UIProcess/WebContext.cpp:567 > + // FIXME: Can we encode the message body outside the loop for all the processes? Please add another FIXME here too - we should fail to send the message if the body contains any references to WKPageRefs/WKFrameRefs etc since they're local to a process. Committed <http://trac.webkit.org/changeset/129575>. |